Skip to content

Add compiler-builtins to bootstrap #142106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add compiler-builtins to bootstrap #142106

wants to merge 2 commits into from
+53 −0

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jun 6, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jun 6, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 6, 2025
@tgross35 tgross35 marked this pull request as draft June 6, 2025 05:09
@tgross35 tgross35 marked this pull request as ready for review June 6, 2025 05:10
@tgross35
Copy link
Contributor Author

tgross35 commented Jun 6, 2025 •
edited
Loading

Bootstrap people, I think I need some help here making this actually work :) ideally these tests should probably run via path (./x t compiler-builtins, ./x t library/compiler-builtins) as well as under ./x library, but I can't quite figure that out.

It would be good for this to run on CI, as well.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
Kobzol
Kobzol reviewed Jun 6, 2025
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. I noticed that compiler-builtins has its own workspace, but at the same time, it doesn't have a Cargo.lock file. I wonder how do we want to deal with that, the dependencies probably should be locked. Either we should add a lockfile to it, or we should somehow make it a part of the root workspace? 🤔

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-19-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@Kobzol Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tgross35 @rustbot @rust-log-analyzer @Kobzol